Support trailing commas and semis #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They will be just removed when formatting, allowing more "sloppy" code before reformatting, increasing usability of erlfmt.
facebook-github-bot
added
the
CLA Signed
|
I don't think I can persuade you folks from discarding this idea, but FWIW… It doesn't seem like a great one to me as it might just hide issues (particularly missing or misplaced clauses or expressions in a function). Is there any possibility that you would consider using a configuration parameter to enable/disable this behaviour? I don't mind if it's in "patch sloppy code" mode as a default, but I would very much like to be able to set it to "I can fix my syntax errors myself, thank you very much" mode. |
|
Woah… took me too much to write that comment, I see… 🤷🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They will be just removed when formatting, allowing more "sloppy" code before reformatting, increasing usability of erlfmt.