Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.0.0: fix pfm and add ibc hooks #232

Merged
merged 18 commits into from
Sep 25, 2023
Merged

v3.0.0: fix pfm and add ibc hooks #232

merged 18 commits into from
Sep 25, 2023

Conversation

faddat
Copy link
Collaborator

@faddat faddat commented Sep 6, 2023

Description and Motivation

This is the full v3 upgrade for migaloo, including upgrade handlers. It should not yet be merged, because we want to check over the upgrade hander before merge. On merge, this will form a new testnet and mainnet. Governance proposal slated to go up 9/16/2023

Related Issues


Checklist:

  • I have read Migaloo's contribution guidelines.
  • My pull request has a sound title and description (not something vague like Update index.md)
  • All existing and new tests are passing.
  • I updated/added relevant documentation.
  • The code is formatted properly golangci-lint run ./... --fix.

@faddat faddat marked this pull request as ready for review September 11, 2023 04:21
app/app.go Outdated Show resolved Hide resolved
app/app.go Outdated Show resolved Hide resolved
app/app.go Outdated Show resolved Hide resolved
@faddat faddat marked this pull request as draft September 15, 2023 09:21
@faddat faddat changed the title add ibc hooks and begin upgrade prep v3.0.0: fix pfm and add ibc hooks Sep 15, 2023
@expertdicer
Copy link
Contributor

I think after merging the #246, we are good to go. cc: @faddat @hoangdv2429

@faddat faddat marked this pull request as ready for review September 20, 2023 17:08
@faddat
Copy link
Collaborator Author

faddat commented Sep 20, 2023

Agree. In the future please work with other codeowners if I'm not available, but looks like great work guys!

<3

…r-fix

Remove unused upgrades and comment
expertdicer
expertdicer previously approved these changes Sep 20, 2023
app/app.go Show resolved Hide resolved
@faddat
Copy link
Collaborator Author

faddat commented Sep 20, 2023

In constants.go for the v3 upgrade, I noticed that we had the version set as v2.2.5. I've changed that to v3.0.0

@faddat
Copy link
Collaborator Author

faddat commented Sep 20, 2023

moment while I check on the contract keeper

@faddat
Copy link
Collaborator Author

faddat commented Sep 20, 2023

@faddat faddat dismissed expertdicer’s stale review September 20, 2023 17:33

I made changes after the review, and would like a re-review.

@faddat
Copy link
Collaborator Author

faddat commented Sep 20, 2023

@expertdicer - sir, I think that in my own re-review, I found two issues:

  • the on-chain version for the upgrade needed to be updated to v3.0.0
  • We hadn't set the contract keeper

I have fixed both of these and re-requested your review.

Thanks!

<3 -Jacob

Copy link
Contributor

@sontrinh16 sontrinh16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should add this after intialize value for TransferKeepr in app.go line 564: app.RouterKeeper.SetTransferKeeper(app.TransferKeeper)

app/app.go Show resolved Hide resolved
app/app.go Show resolved Hide resolved
@hoangdv2429 hoangdv2429 self-requested a review September 21, 2023 04:57
.gitignore Outdated Show resolved Hide resolved
@faddat faddat merged commit 1cda183 into release/v3.0.x Sep 25, 2023
15 checks passed
@Sen-Com Sen-Com deleted the faddat/ibc-hooks branch June 3, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants