-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to desktop environments #315
Conversation
37be44a
to
791ab79
Compare
791ab79
to
f7a1284
Compare
# Conflicts: # tests/run_tests.sh
Add the configuration to connect Desktop env with remote desktop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes to improve the workflow and code style
pengwin-setup.d/desktop.sh
Outdated
|
||
function install_dependencies() { | ||
local dependencies_instaled | ||
echo "installing dependencies" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Capitalize "Installing"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
pengwin-setup.d/desktop.sh
Outdated
sudo bash -c 'cat > /usr/local/bin/remote_desktop.sh' << EOF | ||
#!/bin/bash | ||
|
||
function execute_remote_desktop(){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a space before the {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Fix some misspelling Improve the code Resolve some comments from PR
No description provided.