Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a rule to suggest @Binds over @Provides #19

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Adding a rule to suggest @Binds over @Provides #19

wants to merge 1 commit into from

Conversation

WhosNickDoglio
Copy link
Owner

@WhosNickDoglio WhosNickDoglio commented Apr 8, 2023 •
edited by github-actions bot
Loading

Description

Related Issue

Motivation and Context

Implementation Summary

Checklist

  • My code follows the style guidelines of this project (gradlew detektAll)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I hae mentioned changes in CHANGELOG.md.
  • I have read the CONTRIBUTING document.

@WhosNickDoglio WhosNickDoglio force-pushed the favors-binds branch 3 times, most recently from f44e26f to 6940c06 Compare April 6, 2024 15:25
@WhosNickDoglio WhosNickDoglio force-pushed the favors-binds branch 2 times, most recently from fa6205a to b6fcef5 Compare April 20, 2024 13:13
@WhosNickDoglio WhosNickDoglio force-pushed the favors-binds branch 2 times, most recently from 7ab4c3f to d221c65 Compare June 1, 2024 03:28
@WhosNickDoglio WhosNickDoglio force-pushed the favors-binds branch 2 times, most recently from 870a0c9 to 59cecec Compare June 14, 2024 01:52
@WhosNickDoglio WhosNickDoglio force-pushed the favors-binds branch 3 times, most recently from 6557bf8 to 6050ae6 Compare July 13, 2024 14:31
@WhosNickDoglio WhosNickDoglio force-pushed the favors-binds branch 2 times, most recently from 92624a6 to 478ccae Compare September 14, 2024 00:00
@WhosNickDoglio WhosNickDoglio force-pushed the favors-binds branch 2 times, most recently from 3e337e1 to bfb6746 Compare November 2, 2024 16:30
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 2, 2024 •
edited
Loading

Warnings
⚠️

Any major changes should be added to our CHANGELOG.md file
Changelog format is based on Keep a Changelog.

Generated by 🚫 Danger Kotlin against 08a1bdd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@WhosNickDoglio