Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ConstructorInjectionOverFieldInjectionDetector to be configured when using AppComponentFactory #237

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

WhosNickDoglio
Copy link
Owner

@WhosNickDoglio WhosNickDoglio commented Apr 7, 2024

Description

Related Issue

Checklist

  • My code follows the style guidelines of this project (./gradlew lint spotlessCheck)
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings
  • I have mentioned changes in CHANGELOG.md.
  • I have read the CONTRIBUTING document.

Copy link

codecov bot commented Apr 7, 2024

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.31%. Comparing base (c8e49c7) to head (9138d11).

Files with missing lines Patch % Lines
.../ConstructorInjectionOverFieldInjectionDetector.kt 88.23% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #237      +/-   ##
==========================================
- Coverage   89.47%   89.31%   -0.16%     
==========================================
  Files          21       21              
  Lines         741      749       +8     
  Branches       82       85       +3     
==========================================
+ Hits          663      669       +6     
  Misses         50       50              
- Partials       28       30       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WhosNickDoglio WhosNickDoglio force-pushed the configure-constructor-injection branch 2 times, most recently from 4c1efe8 to 6c96c04 Compare April 20, 2024 13:13
@WhosNickDoglio WhosNickDoglio force-pushed the configure-constructor-injection branch from 6c96c04 to b89d788 Compare April 27, 2024 19:58
@WhosNickDoglio WhosNickDoglio force-pushed the configure-constructor-injection branch 2 times, most recently from ee9a56f to e444f79 Compare June 1, 2024 03:28
@WhosNickDoglio WhosNickDoglio force-pushed the configure-constructor-injection branch 2 times, most recently from 86c1621 to f7b7819 Compare June 14, 2024 01:52
@WhosNickDoglio WhosNickDoglio force-pushed the configure-constructor-injection branch 3 times, most recently from 5117451 to 566b17b Compare July 13, 2024 14:31
@WhosNickDoglio WhosNickDoglio force-pushed the configure-constructor-injection branch from 566b17b to a7f8933 Compare July 28, 2024 12:45
@WhosNickDoglio WhosNickDoglio force-pushed the configure-constructor-injection branch from a7f8933 to e9e46a8 Compare August 25, 2024 15:57
@WhosNickDoglio WhosNickDoglio force-pushed the configure-constructor-injection branch 3 times, most recently from f999ba7 to 63948bf Compare September 13, 2024 23:57
@WhosNickDoglio WhosNickDoglio force-pushed the configure-constructor-injection branch from 63948bf to 3ad7bec Compare October 19, 2024 02:58
@WhosNickDoglio WhosNickDoglio force-pushed the configure-constructor-injection branch 2 times, most recently from f4b9e72 to b02ae87 Compare November 2, 2024 16:30
Copy link
Contributor

github-actions bot commented Nov 2, 2024

Warnings
⚠️

Any major changes should be added to our CHANGELOG.md file
Changelog format is based on Keep a Changelog.

Generated by 🚫 Danger Kotlin against 9138d11

@WhosNickDoglio WhosNickDoglio force-pushed the configure-constructor-injection branch from b02ae87 to 9138d11 Compare November 16, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant