Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag DefineComponent should be interfaces #373

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

WhosNickDoglio
Copy link
Owner

@WhosNickDoglio WhosNickDoglio commented Sep 14, 2024

Description

Related Issue

Checklist

  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have mentioned changes in CHANGELOG.md.
  • I have read the CONTRIBUTING document.

PR Stack

Copy link

codecov bot commented Sep 14, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.48%. Comparing base (c8e49c7) to head (714cd3f).

Files with missing lines Patch % Lines
.../dev/whosnickdoglio/hilt/HiltRulesIssueRegistry.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #373      +/-   ##
==========================================
+ Coverage   89.47%   89.48%   +0.01%     
==========================================
  Files          21       21              
  Lines         741      742       +1     
  Branches       82       82              
==========================================
+ Hits          663      664       +1     
  Misses         50       50              
  Partials       28       28              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WhosNickDoglio WhosNickDoglio force-pushed the feature/ndoglio/definecomponent-interface branch from 64d12f7 to 4f977ac Compare October 19, 2024 02:58
@WhosNickDoglio WhosNickDoglio force-pushed the feature/ndoglio/definecomponent-interface branch 2 times, most recently from 3e04626 to 6c2c630 Compare November 2, 2024 16:30
Copy link
Contributor

github-actions bot commented Nov 2, 2024

Warnings
⚠️

Any major changes should be added to our CHANGELOG.md file
Changelog format is based on Keep a Changelog.

Generated by 🚫 Danger Kotlin against 714cd3f

@WhosNickDoglio WhosNickDoglio force-pushed the feature/ndoglio/definecomponent-interface branch from 6c2c630 to 714cd3f Compare November 16, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant