[NEW] Hide Print for App Compatibility #148
Conversation
src/lib/room.js
Outdated
| if (isWebView()) { | ||
| // Hide Print | ||
| store.setState({ hidePrint: true }); | ||
| parentCall('hidePrint'); | ||
| } |
There was a problem hiding this comment.
@AlexanderKanakis This is just setting hidePrint flag when the widget is running in the webview. But I think what we want to achieve is when hidePrint is true we want to not show the Save Transcript button. Is that correct @ear-dev?
There was a problem hiding this comment.
yes, that is correct @Shailesh351 We should not be setting either hidePrint or showPrint... we should allow the integration script to call the method it wants, and we should check it for True/False, and respond accordingly
AlexanderKanakis
changed the title
|
@AlexanderKanakis please let Shailesh know when it's ready to be reviewed again... thanks |
| return transcript && (!store.state.hidePrint || enableTranscriptMobile); | ||
| } | ||
| return transcript; | ||
| return transcript && !store.state.hidePrint; |
There was a problem hiding this comment.
Instead of this how about just returning false when hidePrint is true?
const { hidePrint } = store.state;
if (hidePrint) {
return false;
}
There was a problem hiding this comment.
@AlexanderKanakis Functionality is working fine. Just one thing... for this much change generally there are only 6-10 build file changes, but in this PR there are around 200. Can you make sure it's up to date?
I generally do yarn build on the latest commit for updating build files
|
@Shailesh351 I did update my build files after committing my latest changes. The problem might be that after I created my branch from |
|
@AlexanderKanakis You can try building again after resolving merge conflicts |
No description provided.