Update build, publish mechanism #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make installation in MMW faster
rajadain
force-pushed
the
tt/92/deploy-via-github-actions
branch
from
aa5720b to
ee239a6
Compare
|
Dependency install fails for me unfortunately: At first I thought it was because of being on Python 3.10.14 instead of 3.10, so I tried recreating my virtual environment to 3.10.0... still no dice: Removed my virtual environment, and it made further progress but still ultimately did not succeed: As a final effort, I set the |
|
This is very useful, thanks! You're on an M1 Mac? |
|
It looks like you're doing all the above on |
|
Thanks so much for the reminder on switching branches! This helped me progress further but unfortunately attempts to install I was surprised to see the error says there's no matching distribution found for |
|
So the true error for the above is this one: which can be solved by the The package is really designed to work in a Linux environment, and the wheels added as part of this PR are for Linux x64 environments. On an ARM MacOS, we'd have to build it locally. This can be done as such: $ cd <project_dir>
$ mkdir test && cd test/
$ python3.10 -m venv .venv
$ source .venv/bin/activate
(.venv) $ pip install -r ../requirements.txt
(.venv) $ pip install build wheel
(.venv) $ pip install -i https://test.pypi.org/simple/ --no-build-isolation gwlf-e==3.2.0This will create a new virtual environment, install the correct dependencies from the main PyPI index (for they will not be available in TestPyPI so cannot be installed transitively), install the build dependencies, and then compile and install the final piece. Let me know if the above works. |
|
The revised steps worked, install completed successfully: Do these steps (the original and revised for ARM MacOS) need to be documented in TestPyPI?
|
|
Good catch. Added instructions in 0bc505d, and made that go to PyPI in 3afb5e6. See demo here: https://test.pypi.org/project/gwlf-e/3.2.1/ 
|
|
Reverted accidental version bump in c0bb882. I had done that locally to push 3.2.1 to TestPyPI. The real version bump will happen when exercising the release workflow, after this is merged. |
With this gone, PyPI will now use README for its documentation, which is a lot more relevant.
rajadain
force-pushed
the
tt/92/deploy-via-github-actions
branch
from
c0bb882 to
9f199c0
Compare
|
Thanks for shepherding this in! Squashed fixups, will wait for CI to pass before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Since gwlf-e is primarily installed on Linux VMs for MMW, it is useful for there to be binary Linux wheels for common Python versions available.
This PR builds and publishes binary Linux wheels for Python 3.8 (current version on MMW), 3.9, and 3.10 (next version on MMW).
It also adds a GitHub Action to do releases instead of the previous manual process, and updates the README. PyPI has been configured to trust this new GitHub Action as a publisher as well.
Demo
https://test.pypi.org/project/gwlf-e/3.2.0/
Testing Instructions
pipenv sync --devto install all dependenciespipenv run python -m build --sdistto build a source distributionpipenv run python -m cibuildwheel --output-dir distto build wheelsCloses #92