Fix Concord Login #3486
Merged
Fix Concord Login #3486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajadain
force-pushed
the
release/1.33.3
branch
from
79cd1bd to
4b82f10
Compare
Rather than a simple object, to make it more compliant with other backends.
Without this, the signature of our custom backend does not match that of the function call. This signature is tested in django.contrib.auth.authenticate here: https://github.com/django/django/blob/fdf209eab8949ddc345aa0212b349c79fc6fdebb/django/contrib/auth/__init__.py#L69 and `request` was added to that signature in Django 1.11 in django/django@4b9330c. With this, the Concord users are authenticated correctly.
Previously we assumed that the error would have a message attribute. This is not always the case. Now we only access that when it is available.
rajadain
force-pushed
the
tt/fix-concord-login
branch
from
6926333 to
f5f990c
Compare
emilyhu0106
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Users of the educational platform Concord Learn Portal have been unable to login since the Django upgrade. This happened because the signature that Django looks for in custom backends changed. By changing the signature of our custom backends to bring them back in line with what Django expects, we ensure that Concord users can log in again.
Note that this targets
release/1.33.3, notdevelop.Connects #3467
Demo
Testing Instructions
Setup
oAuth (MMW_ITSI_SECRET_KEY / MMW_CONCORD_SECRET_KEY)appVM and populate theMMW_CONCORD_SECRET_KEYvariable:vagrant ssh app -c 'echo *** | sudo tee /etc/mmw.d/env/MMW_CONCORD_SECRET_KEY'mmw-appservice so it picks up the new variable:vagrant ssh app -c 'sudo service mmw-app restart'MMW Teacher Learn Portal Concordentry in LastPass