forked from wikimedia/mediawiki-extensions-Popups
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EX-23 | Popups experiment #8
Open
latata
wants to merge
76
commits into
REL1_33
Choose a base branch
from
EX-23
base: REL1_33
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add additional type with categories links displayed in the preview instead of text.
…into EX-116 # Conflicts: # resources/dist/index.js # resources/dist/index.js.map.json
…into EX-148 # Conflicts: # resources/dist/index.js # resources/dist/index.js.map.json
EX-135 | Display variant 3 for variant 5 without categories
EX-23 | Disable experiment for test wikis
…into EX-176 # Conflicts: # resources/dist/index.js # resources/dist/index.js.map.json
EX-23 | Remove arrow from popups
EX-23 | Rebuild popups javascripts
EX-23 | Fix no-image handling in variant 4
EX-23 | Popups should have round corners
EX-196 | Use buildTrackingFunction for events in Popup extension
This variant is used in two cases, one is directly as variant 3 and second case is when variant 4 (with Image) don't have Image.
EX-202 | Disable display of popup only for variant with Title
EX-213 | Use ArticleSnippetService for text extraction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.