Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed T203163: List Applications overlapping statistics for waitlisted partners with short description panels #383

Merged
merged 1 commit into from
Jan 6, 2020

Conversation

soumyaa1804
Copy link
Contributor

@soumyaa1804 soumyaa1804 commented Dec 25, 2019

Only the structure of half- timeline and right column is changed using bootstrap grids.

<div class="float-container margin-bottom-2em">
    <div class="row">
          <div class="col-md-8 col-lg-8 col-sm-8">
                <ul class="timeline half-timeline"> ... </ul>
          </div>
          <div class="col-sm-4 col-md-4 col-sm-4 pull-right">
                <div class="hidden-xs alert alert-warning resource-label-warning"> ... </div>
          </div>
     </div>
</div>

Screenshots can be found here: https://phabricator.wikimedia.org/T203163

@Samwalton9
Copy link
Member

Looking good to me - thanks for your contribution! This overlapping has annoyed me for a long time 😅

@Samwalton9 Samwalton9 merged commit 0383ff6 into WikipediaLibrary:master Jan 6, 2020
@Samwalton9
Copy link
Member

If you're looking for another task to work on, I'd recommend https://phabricator.wikimedia.org/T240598 - it gets a little more into the weeds with the email notification systems we have, but is otherwise fairly straightforward. Let me know if anything is unclear there :)

@soumyaa1804
Copy link
Contributor Author

If you're looking for another task to work on, I'd recommend https://phabricator.wikimedia.org/T240598 - it gets a little more into the weeds with the email notification systems we have, but is otherwise fairly straightforward. Let me know if anything is unclear there :)

Ya, I was actually looking for another task! Thanks for the suggestion. :) I'll definitely look into it.

@soumyaa1804 soumyaa1804 deleted the T203163 branch January 6, 2020 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants