Add one linter workflow for all branches

Wiktor-99 · Aug 17, 2024 · 50d454d · 50d454d
1 parent c1c3279
commit 50d454d
Show file tree

Hide file tree

Showing 5 changed files with 44 additions and 118 deletions.
diff --git a/.github/workflows/build_and_test_humble.yaml b/.github/workflows/build_and_test_humble.yaml
@@ -23,32 +23,3 @@ jobs:
             - uses: ros-tooling/action-ros-ci@v0.3
               with:
                   target-ros2-distro: humble
-    ament_lint_general:
-        name: ament_${{ matrix.linter }}
-        runs-on: ubuntu-latest
-        container:
-            image: rostooling/setup-ros-docker:ubuntu-jammy-ros-humble-ros-base-latest
-        strategy:
-            fail-fast: false
-            matrix:
-                linter: [xmllint, pep257]
-        steps:
-            - uses: actions/checkout@v4
-            - uses: ros-tooling/action-ros-lint@v0.1
-              with:
-                  linter: ${{ matrix.linter }}
-                  distribution: humble
-                  package-name: human_detector
-    ament_flake8:
-        name: ament_flake8
-        runs-on: ubuntu-latest
-        container:
-            image: rostooling/setup-ros-docker:ubuntu-jammy-ros-humble-ros-base-latest
-        steps:
-            - uses: actions/checkout@v4
-            - uses: ros-tooling/action-ros-lint@v0.1
-              with:
-                  linter: flake8
-                  distribution: humble
-                  package-name: human_detector
-                  arguments: --config python_linter.flake8
diff --git a/.github/workflows/build_and_test_iron.yaml b/.github/workflows/build_and_test_iron.yaml
@@ -23,32 +23,3 @@ jobs:
             - uses: ros-tooling/action-ros-ci@v0.3
               with:
                   target-ros2-distro: iron
-    ament_lint_general:
-        name: ament_${{ matrix.linter }}
-        runs-on: ubuntu-latest
-        container:
-            image: rostooling/setup-ros-docker:ubuntu-jammy-ros-iron-ros-base-latest
-        strategy:
-            fail-fast: false
-            matrix:
-                linter: [xmllint, pep257]
-        steps:
-            - uses: actions/checkout@v4
-            - uses: ros-tooling/action-ros-lint@v0.1
-              with:
-                  linter: ${{ matrix.linter }}
-                  distribution: iron
-                  package-name: human_detector
-    ament_flake8:
-        name: ament_flake8
-        runs-on: ubuntu-latest
-        container:
-            image: rostooling/setup-ros-docker:ubuntu-jammy-ros-iron-ros-base-latest
-        steps:
-            - uses: actions/checkout@v4
-            - uses: ros-tooling/action-ros-lint@v0.1
-              with:
-                  linter: flake8
-                  distribution: iron
-                  package-name: human_detector
-                  arguments: --config python_linter.flake8
diff --git a/.github/workflows/build_and_test_jazzy.yaml b/.github/workflows/build_and_test_jazzy.yaml
@@ -23,33 +23,3 @@ jobs:
             - uses: ros-tooling/action-ros-ci@v0.3
               with:
                   target-ros2-distro: jazzy
-
-    ament_lint_general:
-        name: ament_${{ matrix.linter }}
-        runs-on: ubuntu-latest
-        container:
-            image: rostooling/setup-ros-docker:ubuntu-noble-ros-jazzy-ros-base-latest
-        strategy:
-            fail-fast: false
-            matrix:
-                linter: [xmllint, pep257]
-        steps:
-            - uses: actions/checkout@v4
-            - uses: ros-tooling/action-ros-lint@v0.1
-              with:
-                  linter: ${{ matrix.linter }}
-                  distribution: jazzy
-                  package-name: human_detector
-    ament_flake8:
-        name: ament_flake8
-        runs-on: ubuntu-latest
-        container:
-            image: rostooling/setup-ros-docker:ubuntu-noble-ros-jazzy-ros-base-latest
-        steps:
-            - uses: actions/checkout@v4
-            - uses: ros-tooling/action-ros-lint@v0.1
-              with:
-                  linter: flake8
-                  distribution: jazzy
-                  package-name: human_detector
-                  arguments: --config python_linter.flake8
diff --git a/.github/workflows/build_and_test_rolling.yaml b/.github/workflows/build_and_test_rolling.yaml
@@ -23,33 +23,3 @@ jobs:
             - uses: ros-tooling/action-ros-ci@v0.3
               with:
                   target-ros2-distro: rolling
-
-    ament_lint_general:
-        name: ament_${{ matrix.linter }}
-        runs-on: ubuntu-latest
-        container:
-            image: rostooling/setup-ros-docker:ubuntu-noble-ros-rolling-ros-base-latest
-        strategy:
-            fail-fast: false
-            matrix:
-                linter: [xmllint, pep257]
-        steps:
-            - uses: actions/checkout@v4
-            - uses: ros-tooling/action-ros-lint@v0.1
-              with:
-                  linter: ${{ matrix.linter }}
-                  distribution: rolling
-                  package-name: human_detector
-    ament_flake8:
-        name: ament_flake8
-        runs-on: ubuntu-latest
-        container:
-            image: rostooling/setup-ros-docker:ubuntu-noble-ros-rolling-ros-base-latest
-        steps:
-            - uses: actions/checkout@v4
-            - uses: ros-tooling/action-ros-lint@v0.1
-              with:
-                  linter: flake8
-                  distribution: rolling
-                  package-name: human_detector
-                  arguments: --config python_linter.flake8
diff --git a/.github/workflows/linters.yaml b/.github/workflows/linters.yaml
@@ -0,0 +1,44 @@
+---
+name: ROS
+
+on:
+    pull_request:
+    push:
+        branches:
+            - foxy*
+            - humble*
+            - iron*
+            - rolling*
+            - main*
+    workflow_dispatch:
+
+jobs:
+    ament_lint_general:
+        name: ament_${{ matrix.linter }}
+        runs-on: ubuntu-latest
+        container:
+            image: rostooling/setup-ros-docker:ubuntu-jammy-ros-humble-ros-base-latest
+        strategy:
+            fail-fast: false
+            matrix:
+                linter: [xmllint, pep257]
+        steps:
+            - uses: actions/checkout@v4
+            - uses: ros-tooling/action-ros-lint@v0.1
+              with:
+                  linter: ${{ matrix.linter }}
+                  distribution: humble
+                  package-name: human_detector
+    ament_flake8:
+        name: ament_flake8
+        runs-on: ubuntu-latest
+        container:
+            image: rostooling/setup-ros-docker:ubuntu-jammy-ros-humble-ros-base-latest
+        steps:
+            - uses: actions/checkout@v4
+            - uses: ros-tooling/action-ros-lint@v0.1
+              with:
+                  linter: flake8
+                  distribution: humble
+                  package-name: human_detector
+                  arguments: --config python_linter.flake8