Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all viewpoints available in manual annotation tool #282

Closed
TanyaStere42 opened this issue May 24, 2023 · 1 comment · Fixed by #508
Closed

all viewpoints available in manual annotation tool #282

TanyaStere42 opened this issue May 24, 2023 · 1 comment · Fixed by #508
Assignees
Labels
enhancement new or improvements on existing features good first issue small, contained tasks that can be done with minimal onboarding
Milestone

Comments

@TanyaStere42
Copy link
Member

TanyaStere42 commented May 24, 2023

Expected Behavior

  1. User is on an encounter looking at gallery
  2. User selects Add annotation from hamburger menu ( opens src/main/webapp/encounters/manualAnnotation.jsp)
  3. In Viewpoint dropdown, all viewpoints from src/main/webapp/encounters/Annotation.java are available. Dropdown also includes a value of ----- to support viewpoint-less algorithms

ex: If VALID_VIEWPOINTS lists the following:

    private static final String[][] VALID_VIEWPOINTS = new String[][] {
        {"up",        "up",            "up",        "up",            "up",       "up",           "up",        "up",          },
        {"upfront",   "upfrontright",  "upright",   "upbackright",   "upback",   "upbackleft",   "upleft",    "upfrontleft"  },
        {"front",     "frontright",    "right",     "backright",     "back",     "backleft",     "left",      "frontleft"    },
        {"downfront", "downfrontright","downright", "downbackright", "downback", "downbackleft", "downleft",  "downfrontleft"},
        {"down",      "down",          "down",      "down",          "down",     "down",         "down",      "down"         }
};

Then the list should contain:
Image

Note that no duplicates are included

Current Behavior

  1. User is on an encounter looking at gallery
  2. User selects Add annotation from hamburger menu ( opens src/main/webapp/encounters/manualAnnotation.jsp)
  3. In Viewpoint dropdown, only the viewpoints that have been previously seen for a species are listed

Community Link
https://community.wildme.org/t/missing-viewpoints-in-add-annotation-functionality/303/4

@TanyaStere42 TanyaStere42 added the enhancement new or improvements on existing features label May 24, 2023
@TanyaStere42 TanyaStere42 added question open investigation to define scope of issue good first issue small, contained tasks that can be done with minimal onboarding and removed question open investigation to define scope of issue labels Mar 26, 2024
NNattoji pushed a commit to NNattoji/Wildbook that referenced this issue Apr 30, 2024
@NNattoji
Copy link
Contributor

Feature tested locally using an image from the web. All viewpoints show up now after the feature implementation.

Screen Shot 2024-04-30 at 11 14 50 AM

NNattoji pushed a commit to NNattoji/Wildbook that referenced this issue May 1, 2024
naknomum added a commit that referenced this issue May 1, 2024
#282 All viewpoints made available in manual annotation
@TanyaStere42 TanyaStere42 added this to the 10.2.0 milestone May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new or improvements on existing features good first issue small, contained tasks that can be done with minimal onboarding
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants