Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamically set Wildbook version via pom.xml Maven build #593

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Dynamically set Wildbook version via pom.xml Maven build #593

merged 1 commit into from
Jun 5, 2024

Conversation

holmbergius
Copy link
Contributor

Restores existing version-setting capability already used and working in pom.xml via Maven.

PR fixes #458

Changes

  • allows ${pom.version} to be replaced in any piece of code during the Maven build and substitute with the version number (e.g., 10.2) defined in pom.xml. This already existed and worked but simply fell out of use. This commit restores it to the place where it is then called in footer.jsp but should be usable anywhere within the view of the Maven build.

@holmbergius holmbergius requested a review from TanyaStere42 June 5, 2024 19:17
@holmbergius holmbergius self-assigned this Jun 5, 2024
TanyaStere42
TanyaStere42 approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@TanyaStere42 TanyaStere42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 love to see it

@TanyaStere42 TanyaStere42 merged commit c0a113b into master Jun 5, 2024
2 checks passed
@TanyaStere42 TanyaStere42 deleted the 458-set-version-in-pom branch June 5, 2024 20:21
Rodhlann pushed a commit to Rodhlann/Wildbook that referenced this pull request Dec 6, 2024
@TanyaStere42
Merge pull request WildMeOrg#593 from WildMeOrg/458-set-version-in-pom
cf2478c 
Dynamically set Wildbook version via pom.xml Maven build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TanyaStere42 TanyaStere42 TanyaStere42 approved these changes

Assignees

@holmbergius holmbergius

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

in-product version number should reflect current release
2 participants
@holmbergius @TanyaStere42