Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

590 react lang selection persist #604

Merged
merged 3 commits into from
Jun 12, 2024

Conversation

erinz2020
Copy link
Contributor

@erinz2020 erinz2020 commented Jun 12, 2024

fixes issue #590
now react pages get and write to the same cookie as jsp pages

@erinz2020 erinz2020 requested a review from naknomum June 12, 2024 14:32
@erinz2020 erinz2020 linked an issue Jun 12, 2024 that may be closed by this pull request
Copy link
Member

@naknomum naknomum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@TanyaStere42 TanyaStere42 merged commit 7b99c17 into master Jun 12, 2024
2 checks passed
@TanyaStere42 TanyaStere42 deleted the 590_react_lang_selection_persist branch June 12, 2024 17:30
Rodhlann pushed a commit to Rodhlann/Wildbook that referenced this pull request Dec 6, 2024
…ion_persist

590 react lang selection persist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

language selection needs to persist between jsp and react pages
3 participants