Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore default locationID selection to bulk import #612

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

holmbergius
Copy link
Contributor

Restores auto-selection of the bulk import-specific locations IDs, properly scoping ID requests as a result when they are sent from the bulk import's page. The lack of this has caused overscoped matching in Wildbook and much slower, very large jobs in WBIA.

Changes

  • Allows for multi-selection of the generated HTML for the locationID selector based on a passed in list of 0 or more location IDs. Retains single locationID selection.
  • Restores scoped location ID selection by default to the location ID pulldown for matching on the bulk import page. Multiple locationIDs in the bulk import Encounters result in each locationID being included in the default scope

image

@holmbergius holmbergius self-assigned this Jun 19, 2024
@holmbergius holmbergius requested a review from naknomum June 19, 2024 06:07
Copy link
Member

@naknomum naknomum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@holmbergius holmbergius merged commit 8f4a88f into master Jun 25, 2024
2 checks passed
@holmbergius holmbergius deleted the restore-locationID-select-bulk-import-ID branch June 25, 2024 01:20
@TanyaStere42 TanyaStere42 added this to the 10.3.0 milestone Aug 20, 2024
Rodhlann pushed a commit to Rodhlann/Wildbook that referenced this pull request Dec 6, 2024
…lect-bulk-import-ID

Restore default locationID selection to bulk import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants