Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

development docker instruction rework #787

Merged
merged 5 commits into from
Sep 25, 2024

Conversation

TanyaStere42
Copy link
Member

@TanyaStere42 TanyaStere42 commented Sep 25, 2024

All copy changes:

  • brought in react requirements and system setup adjustments since react app is required for wildbook to work now
  • added notes for potential system setup confusion
  • used consistent language in referencing different directories (hopefully reduces confusion?)
  • cleaned up duplicate information and updated links

PR does not fix a numbered issue

All copy changes:
- brought in react requirements and system setup adjustments since react app is required for wildbook to work now
- added notes for potential system setup confusion
- used consistent language in referencing different directories (hopefully reduces confusion?)
@TanyaStere42 TanyaStere42 added project_support devops, build changes, etc etc modernization Updating the tech stack iteratively labels Sep 25, 2024
copy changes
- cut down the information that is required for all setup
- added overview of the purpose of this readme
- standardized formatting
link was busted
guidelines are a bit much in with the rest of this read me. changed to a link to the docs
@TanyaStere42 TanyaStere42 marked this pull request as ready for review September 25, 2024 02:58
@TanyaStere42 TanyaStere42 self-assigned this Sep 25, 2024
Copy link
Member

@naknomum naknomum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

with the changes to the frontend/readme, this is no longer accurate. also updated to be linked
@TanyaStere42 TanyaStere42 merged commit f89e32c into main Sep 25, 2024
1 check passed
@TanyaStere42 TanyaStere42 deleted the development-docker-instruction-rework branch September 25, 2024 23:45
Rodhlann pushed a commit to Rodhlann/Wildbook that referenced this pull request Dec 6, 2024
…struction-rework

development docker instruction rework
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
modernization Updating the tech stack iteratively project_support devops, build changes, etc etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants