Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

913 manual annotation page #984

Merged
merged 27 commits into from
Jan 30, 2025
Merged

913 manual annotation page #984

merged 27 commits into from
Jan 30, 2025

Conversation

erinz2020
Copy link
Contributor

@erinz2020 erinz2020 commented Jan 16, 2025 •
edited
Loading

new manual annotation page implemented:

  1. "add annotation" links to new manual annotation page
  2. user must select iaClass, view point and draw an annotation box before submitting
  3. user can draw, delete bounding box
  4. user can drag, edit, rotate bounding box
  5. user can submit successfully and then will be taken to the new successful landing page

PR fixes #913 and #921

@erinz2020 erinz2020 self-assigned this Jan 20, 2025
@erinz2020 erinz2020 force-pushed the 913_manual_annotation_page branch from 5d71815 to 9589def Compare January 21, 2025 16:09
@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

erinz2020 and others added 25 commits January 22, 2025 00:06
@erinz2020
new page, new router
40af9d8
@erinz2020
add and customize slider
7cb818b
@erinz2020
rotate bounding box by operating slider
a4864d6
@erinz2020
some i18n copy and translations
39c854a
@erinz2020
solution #1, rotating is a bit weird
e475562
@erinz2020
offsets required for rotation?
fc8f95a
@erinz2020
use api data
2e4c7e4
@erinz2020
scale down image and calculate scale factor
303e818
@erinz2020
draggable works now
bd564d3
@erinz2020
rotation supports from -360 to 360
820c923
@erinz2020
temporarily support rotate on top-left corner
7bb2e80
@erinz2020
fake post
725c947
@erinz2020
link point to react page
16c2689
@erinz2020
some math work
a9cbdb9
@erinz2020
some mess experiments
501caa5
@erinz2020
omg save it immediately
8bc91db
@erinz2020
successful creation page
7e3ba5e
@erinz2020
pass correct data to successful page
5dce1ca
@erinz2020
seperate post logic to a hook
d9d596e
@erinz2020
use the hook
21afe9c
@erinz2020
i18n translations
47f10f0
@erinz2020
helper functions
25d4e5d
@erinz2020
use hooks
fd65c28
@naknomum @erinz2020
include annotation data in GET media-assets/ID
7584ebc
@erinz2020
display existing bounding boxes
7df4471
@erinz2020 erinz2020 force-pushed the 913_manual_annotation_page branch from a5f1918 to 7df4471 Compare January 22, 2025 00:06
@erinz2020 erinz2020 requested a review from naknomum January 30, 2025 16:52
@erinz2020 erinz2020 linked an issue Jan 30, 2025 that may be closed by this pull request
manual annotation page update #913
Closed
@erinz2020 erinz2020 marked this pull request as ready for review January 30, 2025 16:56
naknomum
naknomum approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@naknomum naknomum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@naknomum naknomum merged commit 716f558 into main Jan 30, 2025
1 check passed
@naknomum naknomum deleted the 913_manual_annotation_page branch January 30, 2025 17:34
@erinz2020 erinz2020 linked an issue Jan 30, 2025 that may be closed by this pull request
successful manual annotation creation page #921
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naknomum naknomum naknomum approved these changes

Assignees

@erinz2020 erinz2020

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

successful manual annotation creation page manual annotation page update
3 participants
@erinz2020 @codecov-commenter @naknomum