Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add InternVL2-8B video model #4

Merged
merged 12 commits into from
Aug 6, 2024
Merged

Conversation

chchenhui
Copy link
Contributor

@chchenhui chchenhui commented Aug 5, 2024

This PR contributes InternVL2 video models. InternVL2 1B, 2B and 8B has passed the local test. For 4B model, there exists a bug in position ids of Phi 3 in the source code modeling_phi3.py when transformers package is the latest. See OpenGVLab/InternVL#405 for more details.

@jdf-prog
Copy link
Collaborator

jdf-prog commented Aug 5, 2024

Hi, in the get_info() function of the adapter, can you change it to video or image? We don't support other keys like raw_video. Also, it will be great if you can also include some information about the model in the get_info() function. After fixing these, I think you code should be merged.

@jdf-prog
Copy link
Collaborator

jdf-prog commented Aug 6, 2024

Hi @chchenhui , I saw there is a modification in unit_test.py. This is not allowed. And what's the reason of changing the param['prompt'] into param['internvl2_prompt']? This params is the interface we have previously defined.
A few things to do:

@chchenhui
Copy link
Contributor Author

Hi @jdf-prog , previously the generated content was very short when using the default prompt text. That's why I tried other prompt text presented in internVL2 demo. I have changed to the default prompt now.

@jdf-prog
Copy link
Collaborator

jdf-prog commented Aug 6, 2024

Hi @jdf-prog , previously the generated content was very short when using the default prompt text. That's why I tried other prompt text presented in internVL2 demo. I have changed to the default prompt now.

I see. No worries, just to remind. Feel free to ping me once you finished the debuging. And thanks for the time for contribution!

@chchenhui
Copy link
Contributor Author

hi @jdf-prog , please check the updates. The code has passed local testing and I have resolved the conflicts with the base branch.

@jdf-prog jdf-prog merged commit 8e4c1d8 into WildVision-AI:main Aug 6, 2024
@jdf-prog
Copy link
Collaborator

jdf-prog commented Aug 6, 2024

Thanks for the contribution, the code has already been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants