Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract our request handler resolution #33

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Redth
Copy link

@Redth Redth commented Apr 23, 2024

Currently the default is to inspect all the assemblies in the current appdomain for types implementing IRequestHandler but it would be nice to be able to customize this resolution. This abstracts the concept out so you can provide your own resolver and suggest the types explicitly that should be used.

Currently the default is to inspect all the assemblies in the current appdomain for types implementing `IRequestHandler` but it would be nice to be able to customize this resolution.  This abstracts the concept out so you can provide your own resolver and suggest the types explicitly that should be used.
@jorgedevs jorgedevs requested a review from ctacke April 23, 2024 21:02
@Redth
Copy link
Author

Redth commented Apr 23, 2024

Maybe instead of the additional layer, just having a Type[] requestHandlerTypes = null parameter on the ctor would be better? We could then fall back to the current logic if that parameter is null (and maybe also if none of the types specified actually implement IRequestHandler).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant