Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds React 18 to peer deps ranges #140

Merged
merged 5 commits into from
Dec 21, 2022
Merged

Conversation

mrspence
Copy link
Contributor

@mrspence mrspence commented Oct 21, 2022

  1. Extended peerDependencies ranges to include React 18

  2. Locked Travis Node JS version to 16 (LTS) so existing build/test scripts continue to work

Fix #137

@Wildhoney
Copy link
Owner

Thanks 👍 are we doing away with Husky?

@mrspence
Copy link
Contributor Author

Ahhh! Well spotted, my mistake - brought the husky back home

@clmnin
Copy link

clmnin commented Nov 7, 2022

@Wildhoney Is the PR ready to be merged? Or should we keep using < react 18?

@lmk123
Copy link

lmk123 commented Nov 24, 2022

Update: I created a fork to solve this problem https://www.npmjs.com/package/@hcfy/react-shadow


I hope this PR will be merged soon, otherwise my project will report the following error when using npm to install dependencies:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: myapp@0.0.0
npm ERR! Found: react@18.2.0
npm ERR! node_modules/react
npm ERR!   react@"^18.2.0" from myapp@0.0.0
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^16.8.0 || ^17.0.0" from react-shadow@19.0.3
npm ERR! node_modules/react-shadow
npm ERR!   react-shadow@"^19.0.2" from myapp@0.0.0
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

I've tried using --force or --legacy-peer-deps, but they both cause other problems, the biggest problem is that this will result in two versions of react in the project, one for 17 and the other for 18.

@mrspence
Copy link
Contributor Author

mrspence commented Nov 24, 2022

@lmk123 existing tests passing; need repo author (@Wildhoney) to confirm it is ready and approve ✅

@Wildhoney
Copy link
Owner

Thanks 👍

@Wildhoney Wildhoney merged commit 467c482 into Wildhoney:master Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update dependency to React 18?
4 participants