-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds React 18 to peer deps ranges #140
Conversation
Thanks 👍 are we doing away with Husky? |
Ahhh! Well spotted, my mistake - brought the husky back home |
@Wildhoney Is the PR ready to be merged? Or should we keep using < react 18? |
Update: I created a fork to solve this problem https://www.npmjs.com/package/@hcfy/react-shadow I hope this PR will be merged soon, otherwise my project will report the following error when using npm to install dependencies:
I've tried using --force or --legacy-peer-deps, but they both cause other problems, the biggest problem is that this will result in two versions of react in the project, one for 17 and the other for 18. |
@lmk123 existing tests passing; need repo author (@Wildhoney) to confirm it is ready and approve ✅ |
Thanks 👍 |
Extended
peerDependencies
ranges to include React 18Locked Travis Node JS version to 16 (LTS) so existing build/test scripts continue to work
Fix #137