Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Markdown diff highilighting #380

Open
wants to merge 170 commits into
base: master
Choose a base branch
from
Open

Conversation

gurjeet
Copy link
Contributor

@gurjeet gurjeet commented Sep 20, 2022

Use MDeiml/tree-sitter-markdown project to support Markdown as a
supported language.

The instructions provided in documentation were used to add this
tree-sitter parser for the Markdown syntax.

gurjeet added a commit to gurjeet/difftastic that referenced this pull request Sep 20, 2022
TreeSitterConfig doesn't seem to have the `name` attribute, anymore.

I discovered this discrepancy while integrating Markdown language parser
in PR Wilfred#380.
Wilfred pushed a commit that referenced this pull request Oct 25, 2022
TreeSitterConfig doesn't seem to have the `name` attribute, anymore.

I discovered this discrepancy while integrating Markdown language parser
in PR #380.
@grunweg
Copy link
Contributor

grunweg commented May 4, 2023

Just came across this today; I'd be interested. Would this PR be merged in principle (I presume yes, based on the manual)?

What's needed to get this PR across the finish line? Rebasing, a regression test, anything else?

@Wilfred
Copy link
Owner

Wilfred commented Aug 26, 2023

Thanks for the PR! I'm hesitant to merge this before #372 is fixed, because changing one word in a large paragraph might be hard to read otherwise.

@helins
Copy link

helins commented Sep 25, 2024

Given the ubiquity of Markdown these days, merging this PR would be very welcome :)
Anything we could do to resolve any hesitation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants