Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightbox gallery title bug #258

Merged

Conversation

alejoroman0605
Copy link
Contributor

Related to Issue #211

Description

I removed the "DotNetNuke.Web.Deprecated" dependency from the EditLightbox view that was causing errors. Fixed the way the IMAGE_TEMPLATE is being generated so that it correctly displays the title and description. I also fixed the bug with the "Hide Title & Description" checkbox not validating and always displaying the title and description of the image.

How Has This Been Tested?

I tested locally

Screenshots (if appropriate):

image

image
image

"Hide Title & Description" checkbox checked
image
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@WillStrohl WillStrohl added the bug label Oct 31, 2024
@WillStrohl WillStrohl added this to the Lightbox 01.16.00 milestone Oct 31, 2024
Copy link
Owner

@WillStrohl WillStrohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@WillStrohl WillStrohl merged commit 26a4e32 into WillStrohl:development Oct 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants