Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moderate issue with got version #41

Closed
DiamondCoder02 opened this issue Sep 26, 2022 · 4 comments
Closed

Moderate issue with got version #41

DiamondCoder02 opened this issue Sep 26, 2022 · 4 comments
Labels
wontfix This will not be worked on

Comments

@DiamondCoder02
Copy link

I have discordjs bot that runs the newest akinator version 4.0.1 and I keep seeing this error.
Is there or will there be a fix for this?
image

@WillTDA
Copy link
Owner

WillTDA commented Sep 26, 2022

Hello 👋 Thanks for bringing this to my attention. I'll be sure to check for any updates to the supporting libraries before publishing the next release (which should be released in a few days). I'll keep this issue open until then. 😃

WillTDA added a commit that referenced this issue Sep 26, 2022
@WillTDA
Copy link
Owner

WillTDA commented Sep 26, 2022

I have updated all of Discord.js Akinator's dependencies to their latest versions. However, even the latest release of @vitalets/google-translate-api, the package Akinator uses to translate extra information, uses vulnerable versions of got it's HTTP request library.

Seeing as @vitalets/google-translate-api has not been updated in 7 months, I will make a fork and update the code myself.

@WillTDA WillTDA added the wontfix This will not be worked on label Sep 26, 2022
@WillTDA
Copy link
Owner

WillTDA commented Sep 26, 2022

After looking through @vitalets/google-translate-api's code, the reason that got is outdated is due to that fact that it is the last version of the package that supported CommonJS.

In the future I may create my own translation library to patch the security vulnerabilities, but the vulnerability mentioned shouldn't really affect your discord bot in anyway.

@WillTDA WillTDA closed this as completed Sep 26, 2022
@DiamondCoder02
Copy link
Author

Yeah, it shouldn't. I'm just annoyed by it. XD
Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants