Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed excess regions that were removed from the api #48

Merged
merged 1 commit into from
Apr 27, 2024

Conversation

BannerBomb
Copy link
Contributor

aki-api no longer uses en_objects or en_animals etc. They only use en, ar, de, cn, etc,

As shown in commit jgoralcz/aki-api@167f057#diff-c67d5ecb0f0d072c796538aa31af225b73f3ce7d1cfd857868df6d4f57b84cb2

aki-api no longer uses en_objects or en_animals etc. They only use en... As shown i commit jgoralcz/aki-api@167f057#diff-c67d5ecb0f0d072c796538aa31af225b73f3ce7d1cfd857868df6d4f57b84cb2
@BannerBomb BannerBomb changed the title Update index.js Removed excess regions that were removed from the api Apr 27, 2024
@WillTDA
Copy link
Owner

WillTDA commented Apr 27, 2024

Thanks for letting me know! It seems I completely overlooked this when implementing the new API yesterday.
The new aki-api release doesn't appear to have a well-documented README reflecting the new changes... might look at contributing to that myself at some point.

After testing your new implementation, the package is broken, since the region is not being set correctly.
I'll go about this by removing the gameType option entirely, committing that part myself, and creating a new major release (v5.0.0).

@WillTDA WillTDA merged commit 97bc8f1 into WillTDA:master Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants