Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin unpacked file extension problem (get_PluginUnpackedFileExtension) #983

Closed
Andreas-Schniertshauer opened this issue Sep 24, 2021 · 4 comments
Labels
Milestone

Comments

@Andreas-Schniertshauer
Copy link

Andreas-Schniertshauer commented Sep 24, 2021

WinMerge 2.16.14 and 2.16.15: I am using the get_PluginUnpackedFileExtension and return .yaml when comparing zip files that contain xml files, the plugin does a xml to yaml transformation, the fileDst name in the UnpackFile function is _WM886C.tmp.yaml, and the file is written correctly to the Temp\WinMerge folder. In the yaml I use '#' as comments and I want to use the WinMerge option 'Ignore comment differences' and 'Complete unhighlight the ignored differences'. For this to work I added to the WinMerge\Edit\Options\Editor\Sysntax\Shell ;yaml.
But this does not work, may be because in the comparison window the xml files names are shown at the top.
Thanks for the help.

@Andreas-Schniertshauer
Copy link
Author

It was fixed here #820, but did not work in all cases.
I found that pressing F5 when in the comparison window it works. but not when the comparison window is opened initially, because in this case in MergeDoc(354) in function CMergeDoc::Rescan GetView(0, 0)->m_CurSourceDef->type != 0 is false and m_filePaths is used that has the xml extension.

sdottaka added a commit that referenced this issue Sep 25, 2021
@sdottaka
Copy link
Member

Fixed in commit 89c7a86

Thank you for the report.

@Andreas-Schniertshauer
Copy link
Author

Now it works when the comparison window is opened initially, but when changing the Edit\Options\Ignore comment differences from OFF to ON while the comparison window is open it does not work, pressing F5 or Ctrl-F5 does not help. When changing the Edit\Options\Ignore comment differences from ON to OFF while the comparison window is open it works.

sdottaka added a commit that referenced this issue Sep 27, 2021
@sdottaka
Copy link
Member

Oh! Thank you for reporting again.
I've fixed the problem with commit acbbd15.

@sdottaka sdottaka added this to the v2.16.16 milestone Oct 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants