Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow changing the number of CPU cores to use while doing folder comp… #1945

Merged
merged 5 commits into from
Jul 25, 2023

Conversation

sdottaka
Copy link
Member

@sdottaka sdottaka commented Jul 23, 2023

…arisons

This PR adds a "Number of CPU cores to use" combobox to the folder comparison progress window, allowing you to change it during the comparison, as shown below.

image

@sdottaka sdottaka marked this pull request as ready for review July 25, 2023 23:30
@sdottaka sdottaka added this to the v2.16.32 milestone Jul 25, 2023
@sdottaka sdottaka merged commit 3a04464 into master Jul 25, 2023
@sdottaka sdottaka deleted the adjust-cpu-cores-folder-compare branch July 25, 2023 23:31
@vivadavid
Copy link

Hi,

In Options > Compare > Folder, the programme displays that I have 15 cores to use. However, during the actual folder comparison, it only shows 1.

@sdottaka
Copy link
Member Author

@vivadavid The explanation here is insufficient, but if a comparison method other than "Full Contents" or "Quick Contents" is selected, using multiple CPU cores will actually slow down the process. Therefore, the combo box is restricted to allow only the selection of "1".

Furthermore, when specifying "Full Contents" or "Quick Contents" as the comparison method, values greater than those specified in the Options window cannot be used.

@vivadavid
Copy link

I didn't know that: thank you for the information, @sdottaka !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants