Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "Defaults" button to the "Options (Colors/System)" dialog. #2506

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

lededev
Copy link
Contributor

@lededev lededev commented Oct 28, 2024

image

@sdottaka
Copy link
Member

Thank you for the PR.

I thought that the Defaults button was unnecessary, because when you want to set the settings on each page in the Colors category to the default, you can simply reselect the color scheme in the Colors/Color Schemes category.

If you were to add a Defaults button, I think it would be better to set default values ​​according to the currently selected color scheme when you press the Defaults button. (This PR does not do this. For example, if you press the Defaults button while the Solarized Dark color scheme is selected, the colors of the status bar etc. will not be those of Solarized Dark.)

@lededev
Copy link
Contributor Author

lededev commented Oct 29, 2024

If you change the color value of the COLOR_ACTIVECAPTION and save it, the change will not be overwritten by switching the color scheme, it will be saved in the "Settings/SysColorHookColors" in the registry, and the default value will be overridden every time it is loaded, which will be overridden by the void PropSysColors::ReadOptions() function. If you change all the color values in the drop-down box, it is very cumbersome to change back to the default values, so the "Defaults" button is necessary.

@sdottaka sdottaka merged commit d17d767 into WinMerge:master Nov 11, 2024
3 checks passed
@sdottaka
Copy link
Member

I've merged it for now.
However, as I mentioned before, I want the default values ​​to reflect the current color scheme, so I plan to modify them later.

sdottaka added a commit that referenced this pull request Nov 11, 2024
…) (2) Set the default value according to the current color scheme.
@sdottaka sdottaka added this to the v2.16.45.0 milestone Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants