-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
additional apps list config for split tunneling on linux #202
Conversation
…s you want to add to the split tunneling app list
There is probably a bug here. I don't think we can accept the patch as is but I'll look into why this might happen. |
Actually, @intangir, I couldn't find any apps on any of my systems that that a .desktop file that meets the following criteria but are not in the default list:
|
neither of these showed up for me, i didn't make sure the paths included correctly to even be searched though
|
Thank you. In the above two examples, waterfox worked fine for me (as long as the file That said, you can just use the '+' icon on the split tunneling apps screen to choose applications not in the default list, so I'm not sure why code changes are necessary? |
In any case I'll make some minor corrections here and credit you. Thanks! |
Oh i guess i didn't noticed the + sign or thought it would open the list,
or maybe it is newer in the last handful of versions? I actually made this
a few months back and only just shared. maybe i just didn't figure out that
functionality though
either way thanks, that will work!
…On Thu, Nov 28, 2024 at 10:35 AM Jason Xu ***@***.***> wrote:
In any case I'll make some minor corrections here and credit you. Thanks!
—
Reply to this email directly, view it on GitHub
<#202 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABZXSB2PAHQRAUOUXUOOIL2C5A4NAVCNFSM6AAAAABSPFS3T6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBWGQ4DGMZQGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
apparently this PR is pointless, still feels empowering to be able to go through the code and get it to work how I needed even if i didn't utilize the existing features correctly, so thanks for that, have a good day |
This adds an additional config file that gets checked on linux, to find apps to be added to the app list for split tunneling:
~/.config/Windscribe/additionalapps.list
the existing code doesn't identify lots of apps you might want to add, even when they have .desktop files for some reason some are still missed, not sure why
rather than figure out why the original code wasn't finding everything i just made this kinda half assed solution of just checking a file for a flat list of file paths to include also. it doesn't bother with icons or anything, just adds the paths and now I can add them to split tunneling and it works for me
not sure if you will want this or not but here's an FYI for you