Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

additional apps list config for split tunneling on linux #202

Closed

Conversation

intangir
Copy link

This adds an additional config file that gets checked on linux, to find apps to be added to the app list for split tunneling:
~/.config/Windscribe/additionalapps.list

the existing code doesn't identify lots of apps you might want to add, even when they have .desktop files for some reason some are still missed, not sure why

rather than figure out why the original code wasn't finding everything i just made this kinda half assed solution of just checking a file for a flat list of file paths to include also. it doesn't bother with icons or anything, just adds the paths and now I can add them to split tunneling and it works for me

not sure if you will want this or not but here's an FYI for you

…s you want to add to the split tunneling app list
@jaxu
Copy link
Contributor

jaxu commented Nov 27, 2024

There is probably a bug here. I don't think we can accept the patch as is but I'll look into why this might happen.

@jaxu
Copy link
Contributor

jaxu commented Nov 27, 2024

There is probably a bug here. I don't think we can accept the patch as is but I'll look into why this might happen.

Actually, @intangir, I couldn't find any apps on any of my systems that that a .desktop file that meets the following criteria but are not in the default list:

  • Must have Type=Application
  • Must not have NoDisplay=true
  • Must have line that starts with Exec=
    If you have examples of such an application please attach the desktop files here so I can investigate.

@intangir
Copy link
Author

intangir commented Nov 27, 2024

neither of these showed up for me, i didn't make sure the paths included correctly to even be searched though
because I also wanted tools like curl, and other command line only tools anyway so i needed a way besides desktop files regardless

intangir@shadow:~$ cat /home/intangir/.local/share/applications/Waterfox.desktop.desktop
#!/usr/bin/env xdg-open

[Desktop Entry]
Version=1.0
Comment=Browse the World Wide Web
GenericName=Web Browser
Keywords=Internet;WWW;Browser;Web;Explorer
Exec=/home/intangir/app/waterfox/waterfox %u
Terminal=false
X-MultipleArgs=false
Type=Application
Icon=/home/intangir/app/waterfox/browser/chrome/icons/default/default128.png
Categories=GNOME;GTK;Network;WebBrowser;
MimeType=text/html;text/xml;application/xhtml+xml;application/xml;application/rss+xml;application/rdf+xml;image/gif;image/jpeg;image/png;x-scheme-handler/http;x-scheme-handler/https;x-scheme-handler/ftp;x-scheme-handler/chrome;video/webm;application/x-xpinstall;
StartupNotify=true
Actions=new-window;new-private-window;

Name[en_US]=Waterfox
Name=Waterfox

Icon[en_US]=/home/intangir/app/waterfox/browser/chrome/icons/default/default128.png

[Desktop Action new-window]
Name=Open a New Window
Exec=firefox -new-window

[Desktop Action new-private-window]
Name=Open a New Private Window
Exec=firefox -private-window

intangir@shadow:~$ cat /usr/share/applications/xdm-app.desktop
[Desktop Entry]
Version=1.0
Encoding=UTF-8
Exec=env GTK_USE_PORTAL=1 /opt/xdman/xdm-app %U
Type=Application
Terminal=false
Name=Xtreme Download Manager
Comment=Xtreme Download Manager
Categories=Network;
Icon=/opt/xdman/xdm-logo.svg
MimeType=application/xdm-app;x-scheme-handler/xdm-app;
StartupNotify=true

@jaxu
Copy link
Contributor

jaxu commented Nov 28, 2024

Thank you. In the above two examples, waterfox worked fine for me (as long as the file /home/intangir/app/waterfox/waterfox actually exists, so if it doesn't show for you please check the path). The second one would indeed not extract correctly; the line containing Exec= starts with 'env' instead of the actual executable, so this will likely show up as /usr/bin/env instead, which is unfortunate but we are never going to parse these perfectly.

That said, you can just use the '+' icon on the split tunneling apps screen to choose applications not in the default list, so I'm not sure why code changes are necessary?

@jaxu
Copy link
Contributor

jaxu commented Nov 28, 2024

In any case I'll make some minor corrections here and credit you. Thanks!

@intangir
Copy link
Author

intangir commented Nov 30, 2024 via email

@intangir
Copy link
Author

apparently this PR is pointless, still feels empowering to be able to go through the code and get it to work how I needed even if i didn't utilize the existing features correctly, so thanks for that, have a good day

@intangir intangir closed this Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants