Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to configure and disable the layers widget #14

Merged
merged 2 commits into from
Feb 8, 2019

Conversation

aarranz
Copy link
Member

@aarranz aarranz commented Feb 8, 2019

This PR changes current widget behaviour to allow to configure the widget to be used for switching between the different layers. This way, it is possible to develop custom widgets for that purpose. In addition to this, it is also possible to disable layer switching at all by providing an empty value for the layer widget preference.

@coveralls
Copy link

coveralls commented Feb 8, 2019

Coverage Status

Coverage increased (+1.06%) to 99.177% when pulling 2acf0f4 on aarranz:feature/custom-layer-widget into b68bcc1 on Wirecloud:develop.

@aarranz aarranz merged commit f8d8a46 into Wirecloud:develop Feb 8, 2019
@fisuda
Copy link
Contributor

fisuda commented Feb 8, 2019

@aarranz
I confirmed that the layerswidget option works. Thanks!

ol3

@aarranz
Copy link
Member Author

aarranz commented Feb 9, 2019

Great 👍. Glad to heard that this PR is useful 😄.

In any case, we think it is only the first step, we need to allow to configure the default base layer, improve the basic layer-selector widget, document how to create a custom widget for switching between layers and so on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants