Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix smooth checkbox and stop referencing removed fields #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mucrow
Copy link

@mucrow mucrow commented Jun 9, 2024

auto smooth was removed, so creating a mesh causes a python error. i have fixed that.

also, smoothing wasn't linked to the smooth checkbox in the first place, so i added that as well

@MetinSeven
Copy link

Thanks for the fixes. Will there be an updated release, or should I use Code button ➔ Download Zip from the main page?

@mucrow
Copy link
Author

mucrow commented Jun 9, 2024

hi @MetinSeven . i'm a random contributer from the internet (i.e., not a maintainer of this repository).

in order for this to be available on the main page, a maintainer at @WiresoulStudio needs to merge my changes and then create a new release.

you can download a zip of my branch, which i will link below, but please be warned that you should always exercise caution when downloading code from random folks on github, myself included lol. i dont have any real method or motivation to demonstrate that you should trust me, but i want folks to know about the risks.

https://github.com/mucrow/W_Mesh_28x/tree/fix-smooth-features

@MetinSeven
Copy link

Great, thanks, much appreciated! 👍

@mucrow
Copy link
Author

mucrow commented Jul 16, 2024

previously, i had copied that logic into the cone and ring primitives too, but they don't have a "smoothed" parameter so it was causing people errors. i have fixed this on my branch.

@Gioni05
Copy link

Gioni05 commented Oct 7, 2024

@mucrow I really like this addon, but there are 2 things that make it look out of place, the fact that there is no icon and the palcement of it in the menu. Could you please help me by indicating the portion of the code i have to change to optain those results?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants