-
-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support SpatiaLite extension #1137
Merged
JoshuaWise
merged 1 commit into
WiseLibs:master
from
merceyz:merceyz/fix/spatialite-support
Feb 22, 2024
Merged
fix: support SpatiaLite extension #1137
JoshuaWise
merged 1 commit into
WiseLibs:master
from
merceyz:merceyz/fix/spatialite-support
Feb 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mceachen
approved these changes
Feb 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks for adding the test, too!
@JoshuaWise when you have a chance, can you check this out please? |
JoshuaWise
approved these changes
Feb 22, 2024
This was referenced Sep 13, 2024
This was referenced Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #230 (comment)
SQLITE_OMIT_GET_TABLE
is set to reduce the binary size, by 4224 bytes in my test, but it causes the SpatiaLite extension to segfault the process.This PR removes
SQLITE_OMIT_GET_TABLE
to support SpatiaLite.Loading
mod_spatialite
works without this PR butSELECT InitSpatialMetaData()
doesn't.Ref #520