Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add linux/arm64 prebuilds for electron #1306

Merged

Conversation

SvetBorislavov
Copy link
Contributor

@SvetBorislavov SvetBorislavov commented Dec 19, 2024

This pull request adds prebuild artifacts for electron linux/arm64

Signed-off-by: Svetoslav Borislavov <svetoslav.borislavov@limechain.tech>
@SvetBorislavov SvetBorislavov changed the title add linux arm64 prebuilds for electron feat: add linux/arm64 prebuilds for electron Dec 19, 2024
@SvetBorislavov SvetBorislavov marked this pull request as ready for review December 19, 2024 09:17
@SvetBorislavov SvetBorislavov requested review from JoshuaWise and a team as code owners December 19, 2024 09:17
Co-authored-by: Pavel Borisov <37436896+PavelSBorisov@users.noreply.github.com>
Copy link
Member

@mceachen mceachen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mceachen mceachen merged commit 08eb06d into WiseLibs:master Dec 27, 2024
@mceachen
Copy link
Member

DERP, I didn't see that this would try to run on arm/v7 -- we got compilation issues from being 32 bit:

https://github.com/WiseLibs/better-sqlite3/actions/runs/12519791498/job/34924508397

/tmp/prebuild/electron/26.0.0/include/node/v8-internal.h:121:59: warning: left shift count >= width of type [-Wshift-count-overflow]
  121 | constexpr size_t kPtrComprCageReservationSize = size_t{1} << 32;
      |                                                 ~~~~~~~~~~^~~~~
/tmp/prebuild/electron/26.0.0/include/node/v8-internal.h:121:59: error: right operand of shift expression '(1 << 32)' is greater than or equal to the precision 32 of the left operand [-fpermissive]
/tmp/prebuild/electron/26.0.0/include/node/v8-internal.h:122:57: warning: left shift count >= width of type [-Wshift-count-overflow]
  122 | constexpr size_t kPtrComprCageBaseAlignment = size_t{1} << 32;
      |                                               ~~~~~~~~~~^~~~~
/tmp/prebuild/electron/26.0.0/include/node/v8-internal.h:122:57: error: right operand of shift expression '(1 << 32)' is greater than or equal to the precision 32 of the left operand [-fpermissive]
/tmp/prebuild/electron/26.0.0/include/node/v8-internal.h:125:27: error: static assertion failed: Pointer compression can be enabled only for 64-bit architectures
  125 |     kApiSystemPointerSize == kApiInt64Size,
      |     ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~

The release is broken until the build.yml is adjusted to not run electron prebuilds on arm/v7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants