Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade all dependencies (including prebuild-install) #702

Merged
merged 1 commit into from
Oct 25, 2021
Merged

Upgrade all dependencies (including prebuild-install) #702

merged 1 commit into from
Oct 25, 2021

Conversation

mceachen
Copy link
Member

Addresses #692 and #694

@mceachen mceachen mentioned this pull request Sep 25, 2021
Closed
@cloverich cloverich mentioned this pull request Oct 6, 2021
Open
@mceachen
Copy link
Member Author

@JoshuaWise is there anything I can do to help expedite merging this?

@mceachen
Copy link
Member Author

...friendly bump...

@JoshuaWise
Copy link
Member

JoshuaWise commented Oct 25, 2021 •
edited
Loading

Sorry for the delay! Just one thing: we can't upgrade mocha because it removes support for Node.js 10, which would require a major version change in better-sqlite3.

@JoshuaWise
Copy link
Member

Merging and reverting mocha...

@JoshuaWise JoshuaWise closed this Oct 25, 2021
@JoshuaWise JoshuaWise reopened this Oct 25, 2021
@JoshuaWise JoshuaWise merged commit ad9b28e into WiseLibs:master Oct 25, 2021
@mceachen mceachen deleted the patch-1 branch June 11, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaWise JoshuaWise JoshuaWise approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mceachen @JoshuaWise