Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prebuild-install to v7.0.0 #724

Merged
merged 1 commit into from
Nov 19, 2021
Merged

Conversation

m4heshd
Copy link
Contributor

@m4heshd m4heshd commented Nov 14, 2021

Fixes #713, #694.

electron-builder uses a dependency named app-builder that uses whatever version of prebuild-install used by the project simply as a peer dependency. So this simple update will fix the issues related to installing pre-built binaries for newer versions of Electron (14.x, 15.x, 16.x).

For the moment, users can run npm install -D prebuild-install@latest on the root project and fix the issue.

@mceachen
Copy link
Member

@m4heshd can you remove your requested review so we can merge this?

@m4heshd
Copy link
Contributor Author

m4heshd commented Nov 16, 2021

@mceachen Hi. I didn't request a review. I think that's because @JoshuaWise is the code owner for everything except workflows.

@mceachen
Copy link
Member

Got it. I didn't know if there was a way on your side to unblock the pr. It'll have to wait for @JoshuaWise then!

@m4heshd
Copy link
Contributor Author

m4heshd commented Nov 16, 2021

Unfortunately yes. Hope he checks the PRs soon.

@JoshuaWise
Copy link
Member

Yeah the code owner thing is not great—it's mostly a temporary measure. I think the correct long-term solution is to transfer better-sqlite3 to a GitHub "organization", which provides has a much more flexible system around adding maintainers and granting contributor rights.

@m4heshd
Copy link
Contributor Author

m4heshd commented Nov 20, 2021

@JoshuaWise I was actually gonna suggest that but it might break stuff that's dependent on API access to this repo. But on the other hand GitHub does provide redirect support when a repo is moved to an organization. I'm not exactly sure how it would work with the GH API and downloading prebuild assets on older builds. I know prebuild-install picks up the repository from package.json. So if the redirects work when it looks for build assets, basically there's nothing else blocking the migration. A pinned poll on the issue tracker might help? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

new version 7.4.4 can not work with electron-builder install-app-deps
3 participants