-
-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update prebuild-install
to v7.0.0
#724
Conversation
@m4heshd can you remove your requested review so we can merge this? |
@mceachen Hi. I didn't request a review. I think that's because @JoshuaWise is the code owner for everything except workflows. |
Got it. I didn't know if there was a way on your side to unblock the pr. It'll have to wait for @JoshuaWise then! |
Unfortunately yes. Hope he checks the PRs soon. |
Yeah the code owner thing is not great—it's mostly a temporary measure. I think the correct long-term solution is to transfer |
@JoshuaWise I was actually gonna suggest that but it might break stuff that's dependent on API access to this repo. But on the other hand GitHub does provide redirect support when a repo is moved to an organization. I'm not exactly sure how it would work with the GH API and downloading prebuild assets on older builds. I know |
Fixes #713, #694.
electron-builder
uses a dependency namedapp-builder
that uses whatever version ofprebuild-install
used by the project simply as a peer dependency. So this simple update will fix the issues related to installing pre-built binaries for newer versions of Electron (14.x, 15.x, 16.x).For the moment, users can run
npm install -D prebuild-install@latest
on the root project and fix the issue.