Skip to content

Commit

Permalink
fix(iOS): add missing call to super method in `RNSScreenView#finalize…
Browse files Browse the repository at this point in the history
…Updates` (software-mansion#1855)

## Description

`RNSScreenView` (iOS) inherits from `RCTViewComponentView` which has
custom implementation of `finalizeUpdates:` method, thus we should call
it.

## Changes

Added missing call to `[super finalizeUpdates:]` in `RNSScreenView`.

## Test code and steps to reproduce

WIP

## Checklist

- [x] Ensured that CI passes
  • Loading branch information
kkafar authored and ja1ns committed Oct 9, 2024
1 parent 089ac75 commit 81f2472
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions ios/RNSScreen.mm
Original file line number Diff line number Diff line change
Expand Up @@ -760,6 +760,7 @@ - (void)updateLayoutMetrics:(const react::LayoutMetrics &)layoutMetrics

- (void)finalizeUpdates:(RNComponentViewUpdateMask)updateMask
{
[super finalizeUpdates:updateMask];
#if !TARGET_OS_TV
[self updatePresentationStyle];
#endif // !TARGET_OS_TV
Expand Down

0 comments on commit 81f2472

Please sign in to comment.