Remove all traces of reflection in ObjectSnapshot #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taluu
force-pushed
the
no-reflection-snapshot
branch
4 times, most recently
from
30a333f
to
1d07a97
Compare
Taluu
force-pushed
the
no-reflection-snapshot
branch
from
1d07a97
to
ddd1028
Compare
|
https://blackfire.io/profiles/compare/e3790154-b2fc-4fa8-b7cd-ed99f55fd271/graph Here is a comparision before / after. Basically, it's about 20 to 40% better :} |
|
Closing, as the target has changed (1.x instead of master) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merry christmas @krichprollsch and @lunika, if this works as it should... ❤️
Basically, removing all traces or dependencies towards Reflection for an ObjectSnapshot. Need to create more tests though with actual objects (see https://gist.github.com/Taluu/2ed4d1d71d5c0db291c4#gistcomment-1657274)
It's a little bit hackish though, even though it is still far more optimized like this.