Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow php 8 #40

Merged
merged 12 commits into from
May 6, 2021
Merged

feat: allow php 8 #40

merged 12 commits into from
May 6, 2021

Conversation

marko-ilic
Copy link
Contributor

No description provided.

Taluu
Taluu suggested changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@Taluu Taluu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things to workout, especially composer stuff.

The other looks fine

src/AbstractSnapshot.php Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
test/AbstractSnapshotTest.php Outdated Show resolved Hide resolved
test/Snapshot/ArraySnapshotTest.php Outdated Show resolved Hide resolved
@healerz
Copy link

healerz commented May 6, 2021

Hi @Taluu
Any chance to merge and release this PR soon? 🙂

Taluu
Taluu approved these changes May 6, 2021
View reviewed changes
Copy link
Contributor

@Taluu Taluu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ! :}

@Taluu Taluu merged commit 410b9a5 into Wisembly:1.x May 6, 2021
@Taluu
Copy link
Contributor

Taluu commented May 6, 2021

Done : https://github.com/Wisembly/Totem/releases/tag/v1.5.0 🎉

@healerz
Copy link

healerz commented May 6, 2021

@Taluu Thank you 👍

@marko-ilic marko-ilic deleted the feat/add-support-for-php8 branch May 13, 2021 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Taluu Taluu Taluu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marko-ilic @healerz @Taluu