Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use withSpan() inside Span decorator #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use withSpan() inside Span decorator #2

wants to merge 1 commit into from

Conversation

Nokitoo
Copy link

@Nokitoo Nokitoo commented Sep 27, 2019

Use withSpan() inside the Span decorator to remove duplicate code.

Evertras
Evertras requested changes Sep 27, 2019
View reviewed changes
Copy link
Collaborator

@Evertras Evertras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node 9x failed as well, may have been a tweak to how async was handled between node versions.

src/Span.ts Outdated Show resolved Hide resolved
@Nokitoo Nokitoo force-pushed the span-decorator-refactor branch 2 times, most recently from 9ad866b to 15d0ea3 Compare September 27, 2019 08:38
Evertras
Evertras reviewed Sep 27, 2019
View reviewed changes
src/Span.ts Outdated Show resolved Hide resolved
@Nokitoo Nokitoo force-pushed the span-decorator-refactor branch from 15d0ea3 to 8e4d4ad Compare September 27, 2019 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evertras Evertras Evertras requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nokitoo @Evertras