This repository has been archived by the owner on Sep 16, 2022. It is now read-only.
Add release submission to Sentry #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpetersson
reviewed
Sep 5, 2019
Dockerfile
Outdated
| @@ -18,6 +18,7 @@ ENV CFSSL_SERVER wott-ca | |||
| # This is such that we can override it during build | |||
| ARG DJANGO_SETTINGS_MODULE=backend.settings.prod | |||
| ENV DJANGO_SETTINGS_MODULE ${DJANGO_SETTINGS_MODULE} | |||
| RUN echo ${CIRCLE_SHA1:-UNKNOWN} > /usr/src/release.txt | |||
There was a problem hiding this comment.
This will not be available inside the docker build. You need to pass it on to Docker here.
|
@rptrchv see Artem's comments in the ticket. |
|
Guys, looks like I misunderstood the concept of docker's env vars, build parameters and their visibility scope. All my experiments with delivering proper value to the Dockerfile level fail. |
|
@rptrchv you're 95% there. Just see this comment. |
|
I'm on it. |
|
Done. |
a-martynovich
force-pushed
the
issue_398
branch
from
1294808
to
87b8586
Compare
a-martynovich
force-pushed
the
issue_398
branch
from
87b8586
to
b5d8135
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're gonna take the last commit hash from a CircleCI's evn (see https://circleci.com/docs/2.0/env-vars/#built-in-environment-variables).
Also I've added a special site url for raising 500 when we need it (for Sentry testing mostly).
Closes #398