-
Notifications
You must be signed in to change notification settings - Fork 2
Replace "Comment" with "Recommended Actions" #472
Replace "Comment" with "Recommended Actions" #472
Conversation
@a-martynovich Could you use a Pill Badge for the number? |
Perfect! Could you also change the 'select all' checkbox to the same style as the other page you just created a PR for. This has been bugging me for a long time. |
@vpetersson It won't look the same because this table is rendered by DataTables JS component, and on the other page the table is in pure HTML. I can try to style the checkbox so that it looks more like a checkbox (because right now it's a button with a checkbox-like icon) or I can try to render it differently. Either way, it's not easy. Let's file an issue for it and decide when it going to be done, because I have lots of other stuff in this sprint. |
Fair enough. Ignore that request for now. |
@vpetersson don't we need a link on the badge, pointing to the actions page? |
Yes good point
…On Tue, Oct 15, 2019 at 11:52 AM rptrchv ***@***.***> wrote:
@vpetersson <https://github.com/vpetersson> don't we need a link on the
badge, pointing to the actions page?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#472?email_source=notifications&email_token=AACXKIAMCCTRPPEGKMJFMADQOWOFLA5CNFSM4JAZCSZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBIKA2Y#issuecomment-542154859>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACXKIEEIHB2GPIHL2MY23LQOWOFLANCNFSM4JAZCSZQ>
.
|
Made it a deep link. |
Closes #459
If the number of recommended actions is zero or undefined (if no portscan or firewall state) the column is empty.