Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of RetroWave OPL3 hardware protocol #195

Merged
merged 2 commits into from
Jan 8, 2023

Conversation

ReimuNotMoe
Copy link
Contributor

Add support of RetroWave OPL3 hardware protocol.

@ReimuNotMoe
Copy link
Contributor Author

Resolves #190

@Wohlstand
Copy link
Owner

I'll review this once I get my home, on a first look, seems good. One note:
We don't use "Egyptian" brackets, so, please follow the code style of project:

if(condition)
{
    some();
}

@ReimuNotMoe
Copy link
Contributor Author

ReimuNotMoe commented Jan 7, 2023

I'll review this once I get my home, on a first look, seems good. One note: We don't use "Egyptian" brackets, so, please follow the code style of project:

if(condition)
{
    some();
}

The coding style is changed now.

Copy link
Owner

@Wohlstand Wohlstand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. I think I'll tweak some other style cases by myself. I'll merge this.

@Wohlstand Wohlstand merged commit 44a988c into Wohlstand:master Jan 8, 2023
@Wohlstand
Copy link
Owner

Sorry for the late reply, I was very tired and slept for a long time.

@ReimuNotMoe
Copy link
Contributor Author

You're welcome. Take care.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants