Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the Adlib Gold file format #98

Merged
merged 2 commits into from
Sep 21, 2018
Merged

Conversation

jpcima
Copy link
Collaborator

@jpcima jpcima commented Sep 20, 2018

Read/Import
EDIT just pushed some minor fixes about code style

@jpcima jpcima force-pushed the adlib-gold-wip branch 2 times, most recently from 5c203a9 to 3051b28 Compare September 20, 2018 23:59
dst.en_4op = (xxP24NNN & 8) != 0;
dst.en_pseudo4op = dst.en_4op && (xxP24NNN & 16) != 0; // pseudo-4op maybe?

//--- rhythm mode percussion: BD=0, SD=1, TOM=2, CYMB=3, HH=4
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instruments structure has the field where you can set percussion instrument as rhythm-mode. Why not to try to also import that?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because I had some doubt on interpreting the fields, but I speculate that's how it would go:

If the bit is_perc is set, then consider rhythm mode and use it.

As I observed from Master of Magic banks, none of drums had the percussion bit set in them. I'm so guessing this must be the purpose.

Have we other examples of BNK2?

@Wohlstand
Copy link
Owner

So, that would be a thing, taking this for a future experiments, then I'll announce on Vogons as some people are having BNK2 files as someone have asked to add BNK2 banks support.

@Wohlstand Wohlstand merged commit 085eeb1 into Wohlstand:master Sep 21, 2018
@Wohlstand Wohlstand mentioned this pull request Sep 21, 2018
2 tasks
@jpcima
Copy link
Collaborator Author

jpcima commented Sep 21, 2018

Also just a quick observation: as you know from Joel's code, a GM number and the belongship to melodic or drum is decided by the instrument's name.

The format does not indicate the percussion key number. If genadldata would class an instrument as drum, it would set it at the default 35. I didn't reciprocate such behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants