Merge pull request #15 from neayi/fix-bug-14

Fixed issue #14
WolfgangFahl · Jan 24, 2023 · 6b796c2 · 6b796c2
2 parents 2b07a1c + 91a8df6
commit 6b796c2
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/PDFEmbed.hooks.php b/PDFEmbed.hooks.php
@@ -112,11 +112,16 @@ static public function generateTag($obj, $args = [], Parser $parser, PPFrame $fr
         } else {
             // https://www.mediawiki.org/wiki/Manual:UserFactory.php
             $revUserName = $parser->getRevisionUser();
+
+            if (empty($revUserName)) {
+                return self::error('embed_pdf_invalid_user');
+            }
+
             $userFactory = MediaWikiServices::getInstance()->getUserFactory();
             $user = $userFactory->newFromName($revUserName);
         }
 
-        if ($user === false) {
+        if (empty($user)) {
             return self::error('embed_pdf_invalid_user');
         }