[Server] Added a setting to change the web video quality

Wolfteam · Dec 12, 2021 · e14e3a9 · e14e3a9
1 parent 12feceb
commit e14e3a9
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 13 deletions.
diff --git a/CastIt.Domain/Enums/WebVideoQualityType.cs b/CastIt.Domain/Enums/WebVideoQualityType.cs
@@ -0,0 +1,12 @@
+namespace CastIt.Domain.Enums
+{
+    public enum WebVideoQualityType
+    {
+        UltraLow = 144,
+        Low = 240,
+        Traditional = 360,
+        Standard = 480,
+        Hd = 720,
+        FullHd = 1080
+    }
+}
diff --git a/CastIt.Server/Services/ServerCastService.cs b/CastIt.Server/Services/ServerCastService.cs
@@ -157,12 +157,6 @@ protected void FileLoaded(object sender, EventArgs e)
             _server.OnFileLoaded?.Invoke(GetCurrentPlayedFile());
         }
 
-        protected Task OnQualitiesLoaded(int selectedQuality, List<int> qualities)
-        {
-            CurrentPlayedFile?.SetQualitiesStreams(selectedQuality, qualities);
-            return Task.CompletedTask;
-        }
-
         public Task PlayFile(string fileName, bool force, bool isAnAutomaticCall)
         {
             if (string.IsNullOrWhiteSpace(fileName))
@@ -327,12 +321,6 @@ public async Task PlayFile(ServerFileItem file, bool force, bool fileOptionsChan
                     CurrentPlayedFile.SetSubtitleStreams(localSubsPath, filename, _settings.LoadFirstSubtitleFoundAutomatically);
                 }
 
-                //TODO: FIGURE OUT HOW CAN I REMOVE THIS
-                if (request is YoutubePlayMediaRequest ytRequest)
-                {
-                    await OnQualitiesLoaded(ytRequest.SelectedQuality, ytRequest.Qualities);
-                }
-
                 if (request.NeedsTinyCode)
                 {
                     await GenerateAndSetTinyCode(request);

diff --git a/CastIt.Shared/Models/ServerAppSettings.cs b/CastIt.Shared/Models/ServerAppSettings.cs
@@ -15,6 +15,7 @@ public class ServerAppSettings
         public bool ForceAudioTranscode { get; set; }
         public VideoScaleType VideoScale { get; set; }
         public bool EnableHardwareAcceleration { get; set; }
+        public WebVideoQualityType WebVideoQuality { get; set; }
 
         public SubtitleFgColorType CurrentSubtitleFgColor { get; set; }
         public SubtitleBgColorType CurrentSubtitleBgColor { get; set; }
@@ -38,6 +39,7 @@ public ServerAppSettings Copy()
                 ForceAudioTranscode = ForceAudioTranscode,
                 VideoScale = VideoScale,
                 EnableHardwareAcceleration = EnableHardwareAcceleration,
+                WebVideoQuality = WebVideoQuality,
 
                 CurrentSubtitleFgColor = CurrentSubtitleFgColor,
                 CurrentSubtitleBgColor = CurrentSubtitleBgColor,
@@ -63,6 +65,7 @@ public ServerAppSettings UpdateWith(ServerAppSettings other)
             ForceAudioTranscode = other.ForceAudioTranscode;
             VideoScale = other.VideoScale;
             EnableHardwareAcceleration = other.EnableHardwareAcceleration;
+            WebVideoQuality = other.WebVideoQuality;
 
             CurrentSubtitleFgColor = other.CurrentSubtitleFgColor;
             CurrentSubtitleBgColor = other.CurrentSubtitleBgColor;

diff --git a/CastIt.Youtube/YoutubeUrlDecoder.cs b/CastIt.Youtube/YoutubeUrlDecoder.cs
@@ -142,7 +142,7 @@ public async Task<YoutubeMedia> Parse(
             CancellationToken cancellationToken = default)
         {
             desiredQuality ??= DefaultQuality;
-            _logger.LogInformation($"{nameof(Parse)}: Trying to parse url = {basicInfo.Url}");
+            _logger.LogInformation($"{nameof(Parse)}: Trying to parse url = {basicInfo.Url}. Desired quality = {desiredQuality}");
 
             string fmt = string.Empty;
             if (IsHtmlPage(basicInfo.Url))