-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
a11y: added ARIA live, chatId and labels for launcher button #120
Open
nzambello
wants to merge
2
commits into
Wolox:master
Choose a base branch
from
RedTurtle:a11y-launcher
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcallegari10
pushed a commit
that referenced
this pull request
Apr 9, 2020
- change date-fns import path - add dependency to useffect in Messages component - change messages reducer to ternary in delete messages handle
This was referenced Apr 9, 2020
Merged
Satya5614
added a commit
to Satya5614/react-chat-widget
that referenced
this pull request
Sep 11, 2023
* Make autofocus configurable * Update readme to add autofocus * Add ability to create 'Quick buttons' above the input area and listen to clicks on them. * Update README * Button styling * bumped webpack bersion and added some plugins * add fixes to redux devtools in prod and bump packages versioning * fix tests and bumped test suit versions * fix container occupying the whole view * add validation to auto scroll * update README * 2.1.3 * show children as a custom launcher * create a custom launcher validator * reset package-lock * add index variable * delete useless parenthesis * validate children existence * change variable names and create launcher name constant * fix repeated code * 2.1.4-beta * fix custom launcher feature * add remove custom messages by index feature * create a notify store change feature * delete subscribe funtion * update imports * return toddle position * Added avatar to header. * Splitted profile and title avatar. * Added vertical alignement to title avatar. * Added titleAvatar to README * add markdown-it, sanitize plugin, supscript plugin, link attr setting plugin * add develop environment * change CONTRIBUTING.md * fix handleNewUserMessage missing * rebase and fixed * fix build and rm nodemon * fix badge not showing issue * change express to webpack-dev-server * clean up * update package json * change project structure * add Badge component test, hideAvatar for continous responses and fix configurations for eslint, babel and webpack * add prefix wlx- to all classes * refactor prefix from wlx to rcw * fix tests * fix yarn.lock * change circle.yml * fix test after merge * delete yarn * add documentation for new features * fix breaking avatar loading * add missing build configuration for Jest * Update README.md fix: README.md’s API Props “customLauncher” 👉 launcher * Fix typo in README * Updated launcher prop docs * Update README.md * Added newline to eof * make message scrolling smoother * Added loader animation to 'Messages' component * Added toggleMsgLoader action * Added toggleMsgLoader dispatcher * Set msgLoader initial state in behavior reducer * Implemented example of loader new feature using new toggleMsgLoader dispatcher * Set toggleMsgLoader export * Moved loader into it's own component * Implemented Loader component * Moved Loader styles * Handle action button to show a new message * move function to utils/message.js Optimize the code * Fixed typo error * Added eof in some files and added class name to quickbutton list * Fixed handleMessageSubmit to avoid whitespaces as userInput * Added word wrapping to avoid long words breaking the widget layout. * Refactored Sender component to use a reference * Refactored Widget layout. The component needs to be present in order to be able to 'slide it out' properly * Replaced animation for transition. If not, the widget will be open and closed everytime the page renders * publish v2.1.5 * Update README.md * Update README.md - Add Stream as sponsor * Update README.md - Update Stream position to match MD file * Update README.md * Update README.md * Update README.md * Update README.md * destructured props * Start v3.0 - Add TypeScript - Update React, Babel, Webpack versions to latest * - Add inital v1 Context configuration - Start migrating components to TS * start redux store migration to TypeScript and migrate first components * delete unused context config * start typescript migration - fix type issues in the redux store - bumped redux adn react-redux versions to latest * - migrate all the components to typescript - change connect react-redux hoc for hooks - fix some store types issues * - remove unnecessary packages for prop types and immutable - change refs to use useRef hook - fix quick buttons feature, reducer and component - fix indentation issues - add timestamp to messages, now they will display underneath the message * - change launcher on toggle function types - change the use on launcher of conditional classes - change state type in create reducer * remove console log * bump version to 3.0 * - Add messages deletion - Add onTextInputChange new prop - Fix addLinkSnippet typing issue * New features - mark messages as read/unread - change badge component to handle automatically new messages received - change prod configuration to export only the widget - bump version to mark the 3.0 beta * - add accesibility features according to Wolox#120 - change date-fns import path - add dependency to useffect in Messages component - change messages reducer to ternary in delete messages handle * - add missing id parameter for the dispatcher - add new functions to the main export - remove badge prop * Update Docs - update README with new props and dispatcher functions - update year on LICENSE * - change action types return - add align start to timestamp in response messages - fix production build to not add the devtools * add dependency on useEffect in Messages component * add types definitions for the exported functions and component * add optional mark in handleQuickButton prop * Update README.md Co-Authored-By: Pablo Ferro <pablo.pyp@gmail.com> * Update README.md Co-Authored-By: Pablo Ferro <pablo.pyp@gmail.com> * Update README.md Co-Authored-By: Pablo Ferro <pablo.pyp@gmail.com> * add missing const in readme * bump package version to 3.0 * fixed message img display * Delete react and react-dom as dependencies and keep it only as peer dependency * image preview * suit mobile * clear code * Added react and react-dom to devDependencies * fixed fullscreen preview * v3.0.1 * Typo fixes on readme * fix typo mistake in readme * change quickButtons reducer to replace the buttons with the new incoming ones * v3.0.2 * styles && body overflow * Added handleSubmit event used for custom validation * Update README.md Fixed render and import issue in example * v3.0.3 - update package.lock * fix handle submit blocking the message to be sent * add missing semicolon * v3.0.4 * v3.0.5 * Add handleToggle prop, a function that fires when the widget is toggled, and that receives the toggle status. * fix autofocus at launching chat * image input in open close button * build * final commit * back to normal * height fix on mobile * fix - web server not working through ngrok * new build * Revert "height fix on mobile" This reverts commit dd59f0a. * update base dependencies * remove react imports in components * update babel to 7.13 * Fix events not firing * remove sponsor section in README * Update Webpack and build tools - Update webpack and webpack-cli to v5 - Update loaders and plugins - Change css build config and add postcss preset env - Remove unused dependencies and plugins * fix: jest works with react 17 and update test * fix behavior when deleting messages passing count and id params * fix: issue 211 * feat: add auto-growing input * remove unused linter and update lock file * show markdown support in the readme * feat: add emoji picker * feat: add auto-growing input * fix: picker position * Resizable widget * Show/Hide badge prop * Resizable - readme update * Resizable - fix readme text * Profile avatar - client avatar added * Profile avatar - show client avatar param removed from user message function * update readme and add flag for enable emojis picker * fix update caret offset when inserting emoji * v3.1.0 * Fix JSX issue on building Change width in sender button * remove build files * v3.1.3 - patch jsx error * v3.1.4 --------- Co-authored-by: Thomas Negrault <thomas.negrault@2spark.com> Co-authored-by: Thomas Negrault <Thomas-Negrault@users.noreply.github.com> Co-authored-by: Goosk <cms@a3j.se> Co-authored-by: mcallegari10 <martin.callegari@wolox.com.ar> Co-authored-by: dcarrilloWolox <david.carrillo@wolox.com.ar> Co-authored-by: Diego Diaz <berith.py@gmail.com> Co-authored-by: Unknown <adantoscano@gmail.com> Co-authored-by: 卷家老大 <lwx_1993@outlook.com> Co-authored-by: Vijay Nandwani <born2bgeeky@gmail.com> Co-authored-by: Pablo Ferro <pablo.pyp@gmail.com> Co-authored-by: damfinkel <dfinkelstein@wolox.com.ar> Co-authored-by: Ivan <tammaroivan@gmail.com> Co-authored-by: wanxiang.long <wanxiang.long@56qq.com> Co-authored-by: Dorian30 <alvaradogdorian@gmail.com> Co-authored-by: Dorian Alvarado <36488701+Dorian30@users.noreply.github.com> Co-authored-by: Nick Parsons <nparsons08@gmail.com> Co-authored-by: Guido Marucci Blas <guidomb@gmail.com> Co-authored-by: fedeGiussa25 <fedegiussa25@hotmail.com> Co-authored-by: haozhe <zhz235959@alibaba-inc.com> Co-authored-by: CarlosHWolox <carlos.hernandez@wolox.cl> Co-authored-by: Umer MiB <mohammadumer704@gmail.com> Co-authored-by: kristian ranstrom <kristian@rainstormtech.com> Co-authored-by: Priyanshu Chauhan <priyanshu911@gmail.com> Co-authored-by: 贰壹 <deletetmr@gmail.com> Co-authored-by: Michael Schersten <mschersten@gmail.com> Co-authored-by: Santiago Arias <santiago.arias@wolox.co> Co-authored-by: Santiago Arias <32374120+SOY4RIAS@users.noreply.github.com> Co-authored-by: muddassirk <mkkhanu72@gmail.com> Co-authored-by: M Inzamam Malik <malikasinger1@gmail.com> Co-authored-by: Renzo Torres <renzo.torres@wolox.com.ar> Co-authored-by: CrisVega08 <cristian.vega08@gmail.com> Co-authored-by: thiagocavalcanti <thiago.ccoliveira@gmail.com> Co-authored-by: Agustin Vazquez <agustin.vazquez@wolox.com.ar>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #119.
I'm introducing two new props for the Launcher:
launcherOpenLabel
andlauncherCloseLabel
.These are used in the
alt
attribute of the images in the button, so screen readers use it to give to users a feedback on what they would do with this button.I also added the
chatId
prop to customize theid
attribute I added in order to handle ARIA live region witharia-controls
andaria-live
.