feat: delete function with count and start id params #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcallegari10
approved these changes
Apr 3, 2020
Merged
|
Hey @mcallegari10, I think we can close this, right? Also, i saw the implementation in v3.0, but it's a little bit different. It seems to me that if you provide (2, "AN_ID"), it'll only remove the message with the id and not the message before it. |
|
@mcallegari10, If it makes sense, I opened this PR containing the fix: #254 |
|
Yeah, it makes sense, the feature was kinda incomplete. @thiagocavalcanti, thanks! I'll review it 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function allows to delete messages, with a count parameter (which counts from the last message to the very first one) and an id parameter in which we can use to start the count from a specific message
ex:
deleteMessages(1) will delete the last message
deleteMessages(2,'2123-12313-123') will delete the message with id '2123-12313-123' and the message before that