Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Peer dependencies fix #180

Merged
merged 2 commits into from
Apr 29, 2020
Merged

Peer dependencies fix #180

merged 2 commits into from
Apr 29, 2020

Conversation

CarlosHWolox
Copy link
Contributor

Fixes

  • Delete react and react-dom as dependencies and keep it only as peer dependency

@mcallegari10
Copy link
Contributor

Can you move them to devDependencies? If we delete them from dependencies at all, the dev will crash because there is no react and react-dom.

@mcallegari10 mcallegari10 merged commit 81d89b9 into master Apr 29, 2020
@CarlosHWolox CarlosHWolox deleted the peer-dependencies branch April 30, 2020 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcallegari10 mcallegari10 mcallegari10 approved these changes

Assignees

@CarlosHWolox CarlosHWolox

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CarlosHWolox @mcallegari10