-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React 17 update #250
Merged
Merged
React 17 update #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update webpack and webpack-cli to v5 - Update loaders and plugins - Change css build config and add postcss preset env - Remove unused dependencies and plugins
mcallegari10
requested review from
pabloferro,
damfinkel,
alejobh and
CrisVega08
April 29, 2021 21:44
CrisVega08
reviewed
Apr 30, 2021
import { useSelector, useDispatch } from 'react-redux'; | ||
import format from 'date-fns/format'; | ||
|
||
import { scrollToBottom } from '../../../../../../utils/messages'; | ||
import { Message, Link, CustomCompMessage, GlobalState } from '../../../../../../store/types'; | ||
import { MessageTypes, Link, CustomCompMessage, GlobalState } from '../../../../../../store/types'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
import { MessageTypes, Link, CustomCompMessage, GlobalState } from '../../../../../../store/types'; | |
import { MessageTypes, Link, CustomCompMessage, GlobalState } from 'src/store/types'; |
@@ -1,9 +1,9 @@ | |||
import React, { useEffect, useRef, useState, ElementRef, ImgHTMLAttributes, MouseEvent } from 'react'; | |||
import { useEffect, useRef, useState, ElementRef, ImgHTMLAttributes, MouseEvent } from 'react'; | |||
import { useSelector, useDispatch } from 'react-redux'; | |||
import format from 'date-fns/format'; | |||
|
|||
import { scrollToBottom } from '../../../../../../utils/messages'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
import { scrollToBottom } from '../../../../../../utils/messages'; | |
import { scrollToBottom } from 'src/utils/messages'; |
CrisVega08
approved these changes
May 10, 2021
Update Webpack and build tools
Update test
krajcikondra
pushed a commit
to krajcikondra/react-chat-widget
that referenced
this pull request
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update React version to v17 and Babel to v7