Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emoji picker #259

Merged
merged 6 commits into from
Jul 29, 2021
Merged

Emoji picker #259

merged 6 commits into from
Jul 29, 2021

Conversation

CrisVega08
Copy link
Contributor

Summary

Screenshots

Chrome

Chrome

Firefox

Firefox

Safari

Safari

Copy link
Contributor

@mcallegari10 mcallegari10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to update the readme with the new feature 😄

end: start + range.toString().length
}
}
export const isFirefox = () => navigator.userAgent.search("Firefox") > 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export const isFirefox = () => navigator.userAgent.search("Firefox") > 0;
export const isFirefox = () => navigator.userAgent.search("Firefox") > 0;

}

return (
<div className="rcw-sender">
<div ref={refContainer} className="rcw-sender">
<button className='rcw-picker-btn' type="submit" onClick={handlerPressEmoji}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add a conditional to hide the emoji picker setting it to true by default. What do you think?

Comment on lines 97 to 98
el.innerHTML = ''
setEnter(false)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
el.innerHTML = ''
setEnter(false)
el.innerHTML = '';
setEnter(false);

setEnter(false)
}
else if(brRegex.test(el.innerHTML)){
el.innerHTML = el.innerHTML.replace(brRegex, '')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
el.innerHTML = el.innerHTML.replace(brRegex, '')
el.innerHTML = el.innerHTML.replace(brRegex, '');

el.innerHTML = el.innerHTML.replace(brRegex, '')
}
}
checkSize()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
checkSize()
checkSize();

Comment on lines -8 to -10
> p {
white-space: pre-wrap;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it ok to delete this? Won't be a problem when using markdown?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes its ok, this style I added in before PR.

const position = getCaretIndex(el)
let characterToEnter = '\n\n';
let prevChar, char = '';
if (position > 0) { // Change this
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this?

@mcallegari10 mcallegari10 merged commit aa47838 into master Jul 29, 2021
@Bonfims
Copy link

Bonfims commented Feb 17, 2022

Hi, awesome job with react-chat-widget.

Is a question about emoji feature, can we set their properties like is designed on emoji-mart git page?

If yes, how can i do that? Would be nice to set i18n propertie to do some translation on it.

Thanks

note: maybe i should have posted this in the questions tab, sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants